Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
1 similar comment
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Fixed the lib path, removed node and user to secrets and removed level 3 tests
Signed-off-by: Urvashi Tiwari <urtiwari.com>
Removed the hostname from result summary
* style edits * fix formatting * more fixes
update config parameters
Update README and user guide with additions and improvements
Sync-up with master
Co-Authored-By: yugang-amd <yugang.wang@amd.com>
README update
Co-Authored-By: yugang-amd <yugang.wang@amd.com>
Add test levels table and update examples.
By enabling nightly build for all branch is to make sure build is working with latest ROCm for all supported branches. Particularly for release branches build need to continue and working till end of support for a particular release series.
using api instead of regular checkout and fetch reduces risk of permission issue on local runner if any at prepare nightly branch matrix stage.
Update prerequisites
add rand init to fp8 action
TypeError: 'type' object is not subscriptable on line 6 of the inline script is from list[str] annotations. That syntax needs Python 3.9+. Removing Python 3.9+ type hints (list[str]) the self-hosted runner uses Python 3.8.
Signed-off-by: Urvashi Tiwari <urtiwari.com>
Running even if the latest tarball matches the last run
Fall back to latest same-line, then same-major, then newest nightly SDK when the exact nightly date is missing on the ROCm SDK listing. Co-authored-by: Cursor <cursoragent@cursor.com>
With find_package() of various module potentially adding CMAKE_MODULE_PATH, there is a chance that with the current code path may not be set and cannot find the utils module.
Nightly RVS packages are built unsigned. A separate signing CI needs a predictable input prefix from the scheduled build. Copies of built artifacts under nightly/unsigned/ (scheduled default branch).
No merge from S3: each run builds a new archive from tonight’s .deb only, then syncs with --delete so the unsigned deb/ tree is not a growing pool. unsigned rpm/ and tar/ use staging + aws s3 sync --delete ; unsigned RPM repodata uses only this run’s RPM (no S3 merge). new job publish-unsigned-latest merges runs/<run_id>/deb.json and rpm-tar.json via rvs-unsigned-publish-latest.sh.
Add more strict checks to ensure stale files are not uploaded into S3.Also protect SECRETS from getting published in log.
Update mibytes output in babel schema
This patch got overritten by mistake on rebase.
Signed-off-by: Urvashi Tiwari <urtiwari.com>
Add level based configs to radeon based ASICs
S3 do not have permission to delete objects.Accumulate files for signing and later stop uploading to nightly/rvs.Additional ARN may help cleanup S3 later. Fix issue with JSON upload issue, installing awscli using pip
S3 sync/pull failure to fetch repo data was ignored and possibly causing repo data corruption. A genuine failure should skip upload and should fix the issue rather than ignore silently.
build_packages_local.sh
After ROCM_VERSION is fully resolved and the tarball base is
applied, it is written back to $GITHUB_ENV. The write is guarded
by [ -n "${GITHUB_ENV:-}" ] so local runs (where GITHUB_ENV is
unset) are unaffected.
build-relocatable-packages.yml — build-ubuntu job
- Added rocm_version to job outputs, sourced from a new
capture-rocm-version step.
- The capture step runs immediately after build_packages_local,
at which point ROCM_VERSION in the shell environment is the
value the script wrote to $GITHUB_ENV —
the actual resolved nightly version.
build-relocatable-packages.yml — publish-unsigned-latest job
- ROCM_VERSION is now taken from GITHUB_ENV instead of
vars.ROCM_VERSION. The static repository variable no longer
influences what gets written into latest.json.
Run nightly schedule earlier at 10:00 UTC
Since rvs is built for x86_64 better to follow convention and move rpm packages under x86_64.
This workflow is indented to promote a specifc release build to unsigned folder for signing and to promote as release candidate.
Good to have x86_64 in the folder structure to follow convention as well as to clarify the package architecture.
Fix command issues with aws s3 ls and logic issue with failed archive pull,latest.json,sha generation and publish.
Remove deprecated GM, SMQT, and PESM modules
These were not used in RVS for sometime, removing to avoid confusion
release repo layout updated from tar->tarball and rpm and debian packages moved from unsigned to unsigned/packages.
publishing layout need to be in sync with all the published product packages. Layout should be tarball packages/rpm packages/deb Same layout is used for Nightly and Release
Remove unused PERF and residual EDP modules
Update test iterations count.
* RVS ROCm 10.1 install updates * update xref links to use latest * Update the tarball filename
avoid third party runner
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist